Skip to content

Commit c55e014

Browse files
authored
chore(build): Remove unused instances of @rollup/plugin-commonjs (#4590)
In four of the five packages in which we're using `@rollup/plugin-commonjs`, it has no effect (removing it doesn't change the bundles at all). This makes sense, because nowhere in those four packages are we importing any CJS modules. This removes those extraneous plugin instances. (The exception is `@sentry/integrations`, because the `Offline` plugin imports `localforage`, which is CJS. As a result, its rollup config hasn't been changed.)
1 parent 9bda61e commit c55e014

File tree

4 files changed

+0
-8
lines changed

4 files changed

+0
-8
lines changed

packages/browser/rollup.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { terser } from 'rollup-plugin-terser';
22
import typescript from 'rollup-plugin-typescript2';
33
import license from 'rollup-plugin-license';
44
import resolve from '@rollup/plugin-node-resolve';
5-
import commonjs from '@rollup/plugin-commonjs';
65
import replace from '@rollup/plugin-replace';
76

87
const commitHash = require('child_process')
@@ -72,7 +71,6 @@ const plugins = [
7271
resolve({
7372
mainFields: ['module'],
7473
}),
75-
commonjs(),
7674
];
7775

7876
const bundleConfig = {

packages/tracing/rollup.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { terser } from 'rollup-plugin-terser';
22
import typescript from 'rollup-plugin-typescript2';
33
import license from 'rollup-plugin-license';
44
import resolve from '@rollup/plugin-node-resolve';
5-
import commonjs from '@rollup/plugin-commonjs';
65
import replace from '@rollup/plugin-replace';
76

87
const commitHash = require('child_process')
@@ -60,7 +59,6 @@ const plugins = [
6059
resolve({
6160
mainFields: ['module'],
6261
}),
63-
commonjs(),
6462
];
6563

6664
const bundleConfig = {

packages/vue/rollup.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { terser } from 'rollup-plugin-terser';
22
import typescript from 'rollup-plugin-typescript2';
33
import license from 'rollup-plugin-license';
44
import resolve from '@rollup/plugin-node-resolve';
5-
import commonjs from '@rollup/plugin-commonjs';
65
import replace from '@rollup/plugin-replace';
76

87
const commitHash = require('child_process')
@@ -60,7 +59,6 @@ const plugins = [
6059
resolve({
6160
mainFields: ['module'],
6261
}),
63-
commonjs(),
6462
];
6563

6664
const bundleConfig = {

packages/wasm/rollup.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { terser } from 'rollup-plugin-terser';
22
import typescript from 'rollup-plugin-typescript2';
33
import resolve from '@rollup/plugin-node-resolve';
4-
import commonjs from '@rollup/plugin-commonjs';
54
import replace from '@rollup/plugin-replace';
65

76
const terserInstance = terser({
@@ -50,7 +49,6 @@ const plugins = [
5049
resolve({
5150
mainFields: ['module'],
5251
}),
53-
commonjs(),
5452
];
5553

5654
function mergeIntoSentry() {

0 commit comments

Comments
 (0)