Skip to content

Commit d772c67

Browse files
Luca ForstnerAbhiPrasad
authored andcommitted
ref: Remove unused _sendEvent method in base client (#5026)
1 parent 75a1ae4 commit d772c67

File tree

2 files changed

+11
-20
lines changed

2 files changed

+11
-20
lines changed

packages/browser/src/client.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,7 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
103103
/**
104104
* @inheritDoc
105105
*/
106-
protected _prepareEvent(event: Event, scope?: Scope, hint?: EventHint): PromiseLike<Event | null> {
107-
event.platform = event.platform || 'javascript';
108-
return super._prepareEvent(event, scope, hint);
109-
}
110-
111-
/**
112-
* @inheritDoc
113-
*/
114-
protected _sendEvent(event: Event): void {
106+
public sendEvent(event: Event): void {
115107
// We only want to add the sentry event breadcrumb when the user has the breadcrumb integration installed and
116108
// activated its `sentry` option.
117109
// We also do not want to use the `Breadcrumbs` class here directly, because we do not want it to be included in
@@ -140,7 +132,15 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
140132
);
141133
}
142134

143-
super._sendEvent(event);
135+
super.sendEvent(event);
136+
}
137+
138+
/**
139+
* @inheritDoc
140+
*/
141+
protected _prepareEvent(event: Event, scope?: Scope, hint?: EventHint): PromiseLike<Event | null> {
142+
event.platform = event.platform || 'javascript';
143+
return super._prepareEvent(event, scope, hint);
144144
}
145145

146146
/**

packages/core/src/baseclient.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -545,15 +545,6 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
545545
}
546546
}
547547

548-
/**
549-
* Sends the passed event
550-
* @param event The Sentry event to send
551-
*/
552-
// TODO(v7): refactor: get rid of method?
553-
protected _sendEvent(event: Event): void {
554-
this.sendEvent(event);
555-
}
556-
557548
/**
558549
* Processes the event and logs an error in case of rejection
559550
* @param event
@@ -631,7 +622,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
631622
this._updateSessionFromEvent(session, processedEvent);
632623
}
633624

634-
this._sendEvent(processedEvent);
625+
this.sendEvent(processedEvent);
635626
return processedEvent;
636627
})
637628
.then(null, reason => {

0 commit comments

Comments
 (0)