Skip to content

Commit dc0fe4f

Browse files
author
Luca Forstner
committed
fix consuming data
1 parent 684dd65 commit dc0fe4f

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

dev-packages/e2e-tests/test-applications/nextjs-14/app/request-instrumentation/page.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ export default async function Page() {
66
await fetch('http://example.com/', { cache: 'no-cache' });
77
await new Promise<void>(resolve => {
88
http.get('http://example.com/', res => {
9+
res.on('data', () => {
10+
// Noop consuming some data so that request can close :)
11+
});
12+
913
res.on('close', resolve);
1014
});
1115
});

dev-packages/e2e-tests/test-applications/nextjs-14/tests/request-instrumentation.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ test('Should send a transaction with a fetch span', async ({ page }) => {
2424
data: expect.objectContaining({
2525
'http.method': 'GET',
2626
'sentry.op': 'http.client',
27-
'sentry.origin': 'auto.http.node.http',
27+
'sentry.origin': 'auto.http.otel.http',
2828
}),
2929
description: 'GET http://example.com/',
3030
}),

packages/nextjs/test/integration/pages/api/http/index.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,13 @@ import { NextApiRequest, NextApiResponse } from 'next';
33

44
const handler = async (_req: NextApiRequest, res: NextApiResponse): Promise<void> => {
55
// make an outgoing request in order to test that the `Http` integration creates a span
6-
await new Promise(resolve =>
7-
get('http://example.com', res => {
8-
res.on('close', resolve);
6+
await new Promise<void>(resolve =>
7+
get('http://example.com/', message => {
8+
message.on('data', () => {
9+
// Noop consuming some data so that request can close :)
10+
});
11+
12+
message.on('close', resolve);
913
}),
1014
);
1115

0 commit comments

Comments
 (0)