-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(utils): Make parameterize
function available through browser and node API
#10085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lms24
merged 11 commits into
getsentry:develop
from
AleshaOleg:feature/parameterize-public-api
Jan 23, 2024
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c4d60a9
Make parameterize function available through browser and node API
AleshaOleg 55bba86
Added exports for parameterized function from node SDK
AleshaOleg 4bbba50
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg ea40fa0
Re-added export of function from browser package
AleshaOleg fffe49a
Moved parameterize export from @sentry/utils to @sentry/core
AleshaOleg e23ac38
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg a301579
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg 1ee501c
Moved parameterize function to @sentry/core
AleshaOleg f3bf884
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg 7092449
Merge branch 'develop' of https://github.com/getsentry/sentry-javascr…
AleshaOleg 01e22b9
Added parameterize function export to bun
AleshaOleg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 1 addition & 3 deletions
4
...owser-integration-tests/suites/public-api/captureMessage/parameterized_message/subject.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
import { parameterize } from '@sentry/utils'; | ||
|
||
const x = 'first'; | ||
const y = 'second'; | ||
|
||
Sentry.captureMessage(parameterize`This is a log statement with ${x} and ${y} params`); | ||
Sentry.captureMessage(Sentry.parameterize`This is a log statement with ${x} and ${y} params`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
import * as Sentry from '@sentry/node'; | ||
import { parameterize } from '@sentry/utils'; | ||
|
||
Sentry.init({ | ||
dsn: 'https://[email protected]/1337', | ||
|
@@ -9,4 +8,4 @@ Sentry.init({ | |
const x = 'first'; | ||
const y = 'second'; | ||
|
||
Sentry.captureMessage(parameterize`This is a log statement with ${x} and ${y} params`); | ||
Sentry.captureMessage(Sentry.parameterize`This is a log statement with ${x} and ${y} params`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,4 +71,5 @@ export { | |
startInactiveSpan, | ||
startSpanManual, | ||
continueTrace, | ||
parameterize, | ||
} from '@sentry/node'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this might cause the bundle size increase. Looks like we don't export anything else from utils so adding the package export here can duplicate some other utils functions that would otherwise be included via the core package.
Pleaes export
parameterize
from@sentry/core
instead and export it here from@sentry/core
. So the chain should be@sentry/utils
@sentry/core
@sentry/browser
@sentry/node