Skip to content

test(cloudflare): add example astro package #10108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 10, 2024
Merged

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 8, 2024

Added a github workflow with missing properties:

      - name: Publish to Cloudflare Pages
        uses: cloudflare/pages-action@v1
        if: steps.cache_built_packages.outputs.cache-hit == ''
        with:
          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
          projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
          directory: build
          gitHubToken: ${{ secrets.GITHUB_TOKEN }}
          workingDirectory: dev-packages/env-tests/cloudflare-astro

@anonrig anonrig force-pushed the add-cloudflare-astro branch 2 times, most recently from 6c30e95 to a1ec2a0 Compare January 8, 2024 20:14
@Lms24
Copy link
Member

Lms24 commented Jan 9, 2024

General question: Is there a reason for making this its own workflow vs adding a job in our build.yml one?

@anonrig anonrig force-pushed the add-cloudflare-astro branch 6 times, most recently from 67efe18 to fe7bf59 Compare January 9, 2024 14:23
@anonrig anonrig marked this pull request as ready for review January 9, 2024 14:23
@anonrig anonrig force-pushed the add-cloudflare-astro branch 3 times, most recently from 07655be to a39349b Compare January 9, 2024 15:12
@anonrig anonrig force-pushed the add-cloudflare-astro branch from 56be3be to ffbc45a Compare January 10, 2024 15:47
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding this and for figuring out the resolution problems! We can also use this test app for some actual e2e tests later on so it's really valuable to have!

@anonrig anonrig enabled auto-merge (squash) January 10, 2024 17:24
@anonrig anonrig merged commit 84791bf into develop Jan 10, 2024
@anonrig anonrig deleted the add-cloudflare-astro branch January 10, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants