feat(core): Streamline integration function results to be compatible #10135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused `setupOnce()` calls again.
size-limit report 📦
|
Lms24
approved these changes
Jan 10, 2024
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
…10135) For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused `setupOnce()` calls again. It would be nicer if we could do away with this, but it is pretty hard as the options for a client currently are types as `Integration[]`, and we use these both for setting & getting, making it hard to change this without breaking anything. Now, this is much easier (it basically just works), with the small downsides of shipping a few more bytes - but we can simply remove this in v8 then.
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
…10135) For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused `setupOnce()` calls again. It would be nicer if we could do away with this, but it is pretty hard as the options for a client currently are types as `Integration[]`, and we use these both for setting & getting, making it hard to change this without breaking anything. Now, this is much easier (it basically just works), with the small downsides of shipping a few more bytes - but we can simply remove this in v8 then.
billyvg
pushed a commit
that referenced
this pull request
Jan 10, 2024
…10135) For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused `setupOnce()` calls again. It would be nicer if we could do away with this, but it is pretty hard as the options for a client currently are types as `Integration[]`, and we use these both for setting & getting, making it hard to change this without breaking anything. Now, this is much easier (it basically just works), with the small downsides of shipping a few more bytes - but we can simply remove this in v8 then.
c298lee
pushed a commit
that referenced
this pull request
Jan 10, 2024
…10135) For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused `setupOnce()` calls again. It would be nicer if we could do away with this, but it is pretty hard as the options for a client currently are types as `Integration[]`, and we use these both for setting & getting, making it hard to change this without breaking anything. Now, this is much easier (it basically just works), with the small downsides of shipping a few more bytes - but we can simply remove this in v8 then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the v7 cycle, in order to make this easier to handle. in v8, we need to remove the unused
setupOnce()calls again.It would be nicer if we could do away with this, but it is pretty hard as the options for a client currently are types as
Integration[], and we use these both for setting & getting, making it hard to change this without breaking anything. Now, this is much easier (it basically just works), with the small downsides of shipping a few more bytes - but we can simply remove this in v8 then.