Skip to content

feat(core): Deprecate Span.instrumenter #10139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 10, 2024

This PR deprecates the instrumenter field on the Span interface and class. The field is not part of the Otel Span API and hence it can't exist publicly on our spans either. After talking with @mydea about the replacement, we can probably replace this with an instanceof check when setting instrumenter on the event in v8. This is breaking though, so for now, we only deprecate it. Users shouldn't need to worry about this field anyway.

@Lms24 Lms24 requested review from mydea and AbhiPrasad January 10, 2024 14:51
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-instrumenter branch 2 times, most recently from 0ea6483 to 6564ff1 Compare January 10, 2024 15:20
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-instrumenter branch from 6564ff1 to 6c70ab5 Compare January 10, 2024 17:15
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-instrumenter branch from 6c70ab5 to d3a8d91 Compare January 10, 2024 17:15
@Lms24 Lms24 enabled auto-merge (squash) January 10, 2024 17:15
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.96 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.35 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.98 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.37 KB (-0.05% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.97 KB (-0.05% 🔽)
@sentry/browser - Webpack (gzipped) 22.3 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.61 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.24 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.08 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.89 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 208.71 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 96.76 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.36 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.04 KB (-0.02% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.72 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.33 KB (-0.07% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.37 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.48 KB (-0.04% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.99 KB (-0.09% 🔽)

@Lms24 Lms24 merged commit 307ec28 into develop Jan 11, 2024
@Lms24 Lms24 deleted the lms/feat-core-deprecate-span-instrumenter branch January 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants