feat(core): Deprecate Span.instrumenter
#10139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
instrumenter
field on theSpan
interface and class. The field is not part of the Otel Span API and hence it can't exist publicly on our spans either. After talking with @mydea about the replacement, we can probably replace this with aninstanceof
check when settinginstrumenter
on the event in v8. This is breaking though, so for now, we only deprecate it. Users shouldn't need to worry about this field anyway.