feat(core): Fix legacy integration class types & export integration functions (WIP) #10143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
added a commit
that referenced
this pull request
Jan 16, 2024
This ensures that all integration classes have both the correct constructor options, as well as the correct instance methods. This is pretty dirty, but since we're going to remove the classes very soon in v8, IMHO that's the easiest approach to make this work properly for our users. Somehow TS complains when using the option types directly, so we inline them for now everywhere, which seems to make it happy. 🤷 soon we'll remove these anyhow! Extracted out of #10143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit WIP, but does the following things:
Transactionintegration, because we don't really document this and it's not clear if we need it.new MyIntegration(options)with type safety for options - which is IMHO the most important typing aspect of the integrations, because the rest is internal, really.satisfies IntegrationFnto ensure they have correct types (^^ this lead to the issue above being highlighted, sadly)Export the integration functions from packages so users can use them
Missing some deprecation message, and maybe some cleanup... And some tests are failing right now.