fix(node): Module name resolution #10144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
basePath
forcreateGetModuleFromFilename
isdirname(process.argv[1])
:But the tests used a trailing slash for the base path:
sentry-javascript/packages/node/test/module.test.ts
Lines 3 to 4 in 84791bf
Which means in some situations the module name can include a leading
.
.The tests need to pass without a trailing slash on the
basePath
!