Skip to content

chore(tests): Update Playwright to 1.40.1 in browser integration tests #10175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 14, 2024

This PR updates Playwright version to 1.40.1 for browser integration tests.

  • Removed deprecated usages like page.type
  • Converted page.click event triggers to page.locator(...).click() aligned with the current docs.
  • Refactored flaky textInput test (it does not seem to flake anymore)

There still are a few flaky tests I don't think they're related to this version update.

@onurtemizkan onurtemizkan force-pushed the onur/update-playwright-browser-int-tests branch 8 times, most recently from 840da5c to aa7a960 Compare January 15, 2024 02:05
Copy link
Contributor

github-actions bot commented Jan 15, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.93 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.68 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.06 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (0%)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.57 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.13 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.97 KB (-0.08% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.42 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.44 KB (-0.17% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.08 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.07 KB (-0.09% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.45 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.11 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.4 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@onurtemizkan onurtemizkan force-pushed the onur/update-playwright-browser-int-tests branch 2 times, most recently from 11f494d to ddd2bbd Compare January 17, 2024 14:53
@onurtemizkan onurtemizkan force-pushed the onur/update-playwright-browser-int-tests branch 2 times, most recently from 456185d to 4db0f1c Compare January 23, 2024 14:25
@onurtemizkan onurtemizkan marked this pull request as ready for review January 24, 2024 12:24
@onurtemizkan onurtemizkan force-pushed the onur/update-playwright-browser-int-tests branch from 4db0f1c to 9502a51 Compare January 24, 2024 12:24
@onurtemizkan onurtemizkan changed the title chore(tests): Update Playwright to latest in browser integration tests chore(tests): Update Playwright to 1.40.1 in browser integration tests Jan 24, 2024
@onurtemizkan onurtemizkan requested a review from lforst January 24, 2024 12:24
@lforst lforst enabled auto-merge (squash) January 25, 2024 11:14
@lforst lforst merged commit 12299c9 into develop Jan 25, 2024
@lforst lforst deleted the onur/update-playwright-browser-int-tests branch January 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants