Prevent truncate method to throw an error when crumb.data.url is undefined
#1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
reviewed
Aug 24, 2017
| @@ -1391,7 +1391,7 @@ Raven.prototype = { | |||
| data = objectMerge({}, crumb.data); | |||
| for (var j = 0; j < urlProps.length; ++j) { | |||
| urlProp = urlProps[j]; | |||
| if (data.hasOwnProperty(urlProp)) { | |||
| if (data.hasOwnProperty(urlProp) && data[urlProp]) { | |||
There was a problem hiding this comment.
Only problem with this is that it will skip empty strings. It's probably safer to explicitly check for undefined. Or alternatively, change truncate to not explode on undefined values.
There was a problem hiding this comment.
My first thought was actually to update truncate. I may amend my commit.
By the way, an empty string does not need to be truncated, and testing falsy values also handle null. So let me know what your preference is.
There was a problem hiding this comment.
By the way, an empty string does not need to be truncated
Good point. Okay, I mean given that there are tests, we can proceed as-is.
benvinegar
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I barely understand how it happened, but RavenJS stored breadcrumbs with undefined
data.url.It caused the
truncate()method to throw an error having for consequence that our Exceptions were never logged into Sentry.Here is a temporary workaround that I made in our app until a fix will be made.
Another solution should have been to prevent undefined
strdirectly intruncate().