Skip to content

fix(cdn): Emit console warning instead of error for integration shims #10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 16, 2024

This is a bit less "in your face" which is probably more appropriate here - it is not really an error, we just want to let the user know that the integration is not doing anything.

fixes getsentry/sentry#63085

This is a bit less "in your face" which is probably more appropriate here - it is not really an error, we just want to let the user know that the integration is not doing anything.
@mydea mydea requested review from lforst and Lms24 January 16, 2024 08:43
@mydea mydea self-assigned this Jan 16, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.12 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.48 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.14 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.52 KB (+0.04% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.09 KB (0%)
@sentry/browser - Webpack (gzipped) 22.44 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.8 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.45 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.28 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.09 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.47 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.52 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.08 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.3 KB (+0.05% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.86 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 22.48 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.55 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.66 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)

@mydea mydea merged commit 139a29a into develop Jan 16, 2024
@mydea mydea deleted the fn/warn-for-integration-shims branch January 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader Script throws error when adding any Integration setting in code config, without it enabled in project settings
3 participants