-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Add domain information to resource span data #10205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add domain information to resource span data #10205
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we update https://github.com/getsentry/sentry-javascript/blob/develop/packages/tracing-internal/test/browser/metrics/index.test.ts with some tests!
make sure you rebase to get the latest fixes from develop branch, and then we can merge! |
…pan-domain-to-span-data
Just for reference for the next time, make sure to use |
@mydea Yup! That's my bad, i'm so used to squash being the default and only option. |
fixes #10206
Adds the following data to resource spans
url.scheme
-> scheme of the resource (https, http, etc)server.address
-> the host of the resource (sentry.io, github.com, etc)url.same_origin
-> wether the resource was fetched from the same origin or not. i.e is a relative resource