Skip to content

feat(core): Add domain information to resource span data #10205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 18, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Jan 16, 2024

fixes #10206

Adds the following data to resource spans
url.scheme -> scheme of the resource (https, http, etc)
server.address -> the host of the resource (sentry.io, github.com, etc)
url.same_origin -> wether the resource was fetched from the same origin or not. i.e is a relative resource

@DominikB2014 DominikB2014 changed the title feat(browser-starfish): add span.domin to span data for resources feat(core): Add span.domin to resource span data Jan 16, 2024
Copy link
Contributor

github-actions bot commented Jan 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.62 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.88 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.77 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.52 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.89 KB (+0.27% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.15 KB (+0.08% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.09% 🔺)
@sentry/browser - Webpack (gzipped) 22.51 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.2 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.81 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.66 KB (+0.25% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.21 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.51 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.48 KB (+0.27% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.46 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.7 KB (+0.24% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.3 KB (+0.14% 🔺)
@sentry/react - Webpack (gzipped) 22.55 KB (+0.14% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.88 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.01 KB (+0.17% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (+0.17% 🔺)

@DominikB2014 DominikB2014 marked this pull request as ready for review January 17, 2024 16:38
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikB2014 DominikB2014 changed the title feat(core): Add span.domin to resource span data feat(core): Add domain information to resource span data Jan 17, 2024
@AbhiPrasad
Copy link
Member

make sure you rebase to get the latest fixes from develop branch, and then we can merge!

@DominikB2014 DominikB2014 merged commit caad0bc into develop Jan 18, 2024
@DominikB2014 DominikB2014 deleted the DominikB2014/add-span-domain-to-span-data branch January 18, 2024 20:35
@mydea
Copy link
Member

mydea commented Jan 19, 2024

Just for reference for the next time, make sure to use squash and merge :) (we sadly can't enforce this right now because we depend on merge commits for gitflow, so you have to make sure to select the correct merge manually 😬 )

@DominikB2014
Copy link
Contributor Author

@mydea Yup! That's my bad, i'm so used to squash being the default and only option.
Looks like supporting squash and merge by branch is quite a common request https://github.com/orgs/community/discussions/10809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send span domain from the SDK
3 participants