Skip to content

build(remix): Pin @vanilla-extract/integrations to make work on Node 14 #10248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jan 18, 2024

fixes #10247

Also remove web-streams-polyfill pin introduced in #10065 because that changed was reverted.

@AbhiPrasad AbhiPrasad requested review from a team, mydea and ale-cota and removed request for a team January 18, 2024 15:00
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@Lms24
Copy link
Member

Lms24 commented Jan 18, 2024

thx for reverting the other pin!

@AbhiPrasad
Copy link
Member Author

Skipped flaky test in 5bb0b1a

@AbhiPrasad
Copy link
Member Author

I ended up disabling all remix e2e tests

@AbhiPrasad AbhiPrasad merged commit 4842dcd into develop Jan 18, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remix-14-vanilla-extract-integrations branch January 18, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix integration tests failing
3 participants