Skip to content

ref: Streamline SDK metadata handling #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

ref: Streamline SDK metadata handling #10251

merged 1 commit into from
Jan 19, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 18, 2024

There have been tries to do this before, but let's see how things stand today...

@mydea mydea requested review from Lms24 and AbhiPrasad January 18, 2024 15:20
@mydea mydea self-assigned this Jan 18, 2024
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once upon a time #4196

This is just way better, so let's stick with it

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd time's a charm I guess 😅 (#7404)

I agree with Abhi, if the size hit isn't worse than in the last attempts, it makes sense to deduplicate this.

@mydea
Copy link
Member Author

mydea commented Jan 18, 2024

Once upon a time #4196

This is just way better, so let's stick with it

Just ~6000 issues/PRs later! xD

Copy link
Contributor

github-actions bot commented Jan 18, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.64 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.91 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.79 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.91 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.19 KB (+0.08% 🔺)
@sentry/browser - Webpack (gzipped) 22.53 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.24 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.85 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.7 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.25 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.62 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 98.6 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.58 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.76 KB (+0.1% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.3 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 22.58 KB (+0.11% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.93 KB (-0.06% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.21 KB (-0.08% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jan 18, 2024

Updating branch so we can include this with release wait nvm tests are failing 😢

@mydea mydea force-pushed the fn/streamline-metadata branch 2 times, most recently from 6ba6bf9 to 8f5beb9 Compare January 19, 2024 08:39
@mydea mydea force-pushed the fn/streamline-metadata branch from 8f5beb9 to 651c39a Compare January 19, 2024 12:37
@mydea
Copy link
Member Author

mydea commented Jan 19, 2024

OK, I managed to cut it down as much as I could in size!

@mydea mydea merged commit f3b2e7d into develop Jan 19, 2024
@mydea mydea deleted the fn/streamline-metadata branch January 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants