Skip to content

feat(feedback): Configure feedback border radius #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2024
Merged

feat(feedback): Configure feedback border radius #10289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae31e82
configure border radius for feedback
c298lee Jan 22, 2024
4d936cc
merge cancel border radius config with input
c298lee Jan 22, 2024
40a9de6
rename variable
c298lee Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/feedback/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const LIGHT_THEME = {
backgroundHover: '#f6f6f7',
foreground: '#2b2233',
border: '1.5px solid rgba(41, 35, 47, 0.13)',
borderRadius: '12px',
boxShadow: '0px 4px 24px 0px rgba(43, 34, 51, 0.12)',

success: '#268d75',
Expand All @@ -39,6 +40,9 @@ const LIGHT_THEME = {
inputForeground: INHERIT,
inputBorder: 'var(--border)',
inputOutlineFocus: SUBMIT_COLOR,

formBorderRadius: '20px',
formContentBorderRadius: '6px',
};

export const DEFAULT_THEME = {
Expand Down
12 changes: 12 additions & 0 deletions packages/feedback/src/types/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ export interface FeedbackTheme {
* Border styling for actor and dialog
*/
border: string;
/**
* Border radius styling for actor
*/
borderRadius: string;
/**
* Box shadow for actor and dialog
*/
Expand Down Expand Up @@ -299,6 +303,14 @@ export interface FeedbackTheme {
* Border styles for form inputs when focused
*/
inputOutlineFocus: string;
/**
* Border radius for dialog
*/
formBorderRadius: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, is form clear here as a prefix (from a user pov) - meaning is it clear what this border radius is referring to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use formTitle, and refer to Feedback form in the docs, so this should be clear

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can see if @Jesse-Box can update this image for us too: https://docs.sentry.io/static/e2e105a53b6f4e5d8a8be9acb8a6ec70/07a9c/user-feedback-widget-customization.png

/**
* Border radius for form inputs
*/
formContentBorderRadius: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure but what about maybe inputBorderRadius or something like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we considered inputBorderRadius, but this applies to the input and the buttons in the form (cancel & submit) so we wanted it to be more clear

}

export interface FeedbackThemes {
Expand Down
2 changes: 1 addition & 1 deletion packages/feedback/src/widget/Actor.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function createActorStyles(d: Document): HTMLStyleElement {
align-items: center;
gap: 8px;

border-radius: 12px;
border-radius: var(--border-radius);
cursor: pointer;
font-size: 14px;
font-weight: 600;
Expand Down
8 changes: 4 additions & 4 deletions packages/feedback/src/widget/Dialog.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function createDialogStyles(d: Document): HTMLStyleElement {
top: var(--top);

border: var(--border);
border-radius: 20px;
border-radius: var(--form-border-radius);
background-color: var(--background);
color: var(--foreground);

Expand Down Expand Up @@ -113,7 +113,7 @@ export function createDialogStyles(d: Document): HTMLStyleElement {
background-color: var(--input-background);
box-sizing: border-box;
border: var(--input-border);
border-radius: 6px;
border-radius: var(--form-content-border-radius);
color: var(--input-foreground);
font-size: 14px;
font-weight: 500;
Expand All @@ -138,7 +138,7 @@ export function createDialogStyles(d: Document): HTMLStyleElement {
.btn {
line-height: inherit;
border: var(--cancel-border);
border-radius: 6px;
border-radius: var(--form-content-border-radius);
cursor: pointer;
font-size: 14px;
font-weight: 600;
Expand Down Expand Up @@ -178,7 +178,7 @@ export function createDialogStyles(d: Document): HTMLStyleElement {
.success-message {
background-color: var(--background);
border: var(--border);
border-radius: 12px;
border-radius: var(--border-radius);
box-shadow: var(--box-shadow);
font-weight: 600;
color: var(--success);
Expand Down
4 changes: 4 additions & 0 deletions packages/feedback/src/widget/Main.css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ function getThemedCssVariables(theme: FeedbackTheme): string {
--error: ${theme.error};
--success: ${theme.success};
--border: ${theme.border};
--border-radius: ${theme.borderRadius};
--box-shadow: ${theme.boxShadow};

--submit-background: ${theme.submitBackground};
Expand All @@ -28,6 +29,9 @@ function getThemedCssVariables(theme: FeedbackTheme): string {
--input-foreground: ${theme.inputForeground};
--input-border: ${theme.inputBorder};
--input-outline-focus: ${theme.inputOutlineFocus};

--form-border-radius: ${theme.formBorderRadius};
--form-content-border-radius: ${theme.formContentBorderRadius};
`;
}

Expand Down