ref(types): Add known attribute keys to SpanAttributes type
#10295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Jan 23, 2024
Comment on lines
+27
to
+30
| 'sentry.origin': string; | ||
| 'sentry.op': string; | ||
| 'sentry.source': string; | ||
| 'sentry.sample_rate': number; |
There was a problem hiding this comment.
I guess the downside is that we can't use the semantic attribute constants defined in @sentry/core (as const instead of the hard-coded names).
There was a problem hiding this comment.
I guess this is better than nothing, still! It's just some type sugar on top, so 🤷 still feels like an improvement!
Lms24
changed the title
SpanAttributesSpanAttributes type
mydea
approved these changes
Jan 23, 2024
Lms24
force-pushed
the
lms/ref-core-add-known-attribute-keys
branch
from
facdb7e to
d1d7823
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(extracted from #10274 to discuss in isolation)
I propose we add known attribute keys to the
SpanAttributestype because this way we canWDYT, is this an improvement to the pure
Recordtype?