Skip to content

fix(tracing): Only create request span if there is active span #10375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 29, 2024
Merged

fix(tracing): Only create request span if there is active span #10375

merged 6 commits into from
Jan 29, 2024

Conversation

AbhiPrasad
Copy link
Member

This was a regression introduced with #10236, we shouldn't arbitrarily call startInactiveSpan given we create transactions under the hood currently.

@AbhiPrasad AbhiPrasad requested a review from mydea January 26, 2024 18:11
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 26, 2024 18:16
@AbhiPrasad AbhiPrasad requested a review from lforst January 26, 2024 18:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.12 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.22 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.95 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.35 KB (-0.09% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.24 KB (-0.1% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.89 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.32 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.51 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.53 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.54 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.44 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.4 KB (-0.17% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.4 KB (-0.04% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.7 KB (-0.05% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 🔽)

@AbhiPrasad AbhiPrasad mentioned this pull request Jan 26, 2024
Closed
Lms24
Lms24 approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We should do a broader audit of where else this could be happening at the moment.

@AbhiPrasad
Copy link
Member Author

image

image

@AbhiPrasad AbhiPrasad merged commit 9690d7d into develop Jan 29, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-span-request-active branch January 29, 2024 20:33
@AbhiPrasad
Copy link
Member Author

FINALLY

This was referenced Jan 29, 2024
Merged
Merged
AbhiPrasad added a commit to getsentry/sentry that referenced this pull request Jan 30, 2024
@AbhiPrasad
ref(js): Update JS SDK to 7.99.0 (#64191)
2dd62db 
https://github.com/getsentry/sentry-javascript/releases/tag/7.99.0

Notably it fixes a pretty bad SDK bug which caused inflated transaction
volume - getsentry/sentry-javascript#10375
snigdhas pushed a commit to getsentry/sentry that referenced this pull request Jan 30, 2024
@AbhiPrasad @snigdhas
ref(js): Update JS SDK to 7.99.0 (#64191)
9ad9d81 
https://github.com/getsentry/sentry-javascript/releases/tag/7.99.0

Notably it fixes a pretty bad SDK bug which caused inflated transaction
volume - getsentry/sentry-javascript#10375
@mydea mydea mentioned this pull request Feb 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbhiPrasad @HazAT @mydea @Lms24