feat(core): Ensure startSpan() can handle spans that require parent
#10386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,7 +1,7 @@ | |||
| import type { Page, Request } from '@playwright/test'; | |||
| import type { EnvelopeItemType, Event, EventEnvelopeHeaders } from '@sentry/types'; | |||
|
|
|||
| const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//; | |||
| export const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//; | |||
Check failure
Code scanning / CodeQL
Missing regular expression anchor
size-limit report 📦
|
mydea
force-pushed
the
fn/startSpanIfParent
branch
from
4aab2aa to
a5108f8
Compare
Lms24
approved these changes
Jan 29, 2024
mydea
force-pushed
the
fn/startSpanIfParent
branch
from
a5108f8 to
d4f2740
Compare
This introduces a new `onlyIfParent` option to the start-span APIs, which, if set, will ensure to not create a span if there is no parent. This PR also uses this option in a few places, esp. for http.client spans, to ensure we do not capture these if there is no ongoing transaction.
mydea
force-pushed
the
fn/startSpanIfParent
branch
from
d4f2740 to
70a7b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
onlyIfParentoption to the start-span APIs, which, if set, will ensure to not create a span if there is no parent. I've added this also for otel to demonstrate this works there as well.This PR also uses this option in a few places, esp. for http.client spans, to ensure we do not capture these if there is no ongoing transaction.
This replaces https://github.com/getsentry/sentry-javascript/pull/10375/files with a more generic solution, and includes the test from #10376 (which passes here as well).