Skip to content

feat(v8): Remove extractTraceparentData export #10559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

AbhiPrasad
Copy link
Member

Instead, import this directly from @sentry/utils.

Should help when we move @sentry/utils into core.

@AbhiPrasad AbhiPrasad requested a review from a team February 7, 2024 19:23
@AbhiPrasad AbhiPrasad self-assigned this Feb 7, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 and removed request for a team February 7, 2024 19:23
@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-extractTraceparentData branch from 0639a2e to 43a3b87 Compare February 12, 2024 14:56
Copy link
Contributor

github-actions bot commented Feb 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.95 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.18 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.11 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.79 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.37 KB (+0.3% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.23 KB (+0.31% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (+0.07% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.08% 🔺)
@sentry/browser - Webpack (gzipped) 22.43 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.09 KB (+0.38% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.6 KB (+0.35% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.59 KB (+0.77% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.64 KB (+0.86% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.93 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.55 KB (+0.59% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.83 KB (+0.61% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.83 KB (+0.75% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.55 KB (+0.16% 🔺)
@sentry/react - Webpack (gzipped) 22.46 KB (+0.09% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.34 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.45 KB (+0.14% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (+0.01% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we no longer export this API in the top level packages?

@AbhiPrasad
Copy link
Member Author

I think we prefer people import it from utils (which will live in core soon enough).

For now let's move forward with removing it as promised with the deprecation. We can always figure out how to bring it back in an alternate fashion.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, makes sense, thx!

@AbhiPrasad AbhiPrasad force-pushed the abhi-remove-extractTraceparentData branch from 43a3b87 to 97cf69e Compare February 12, 2024 17:03
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 12, 2024 17:46
@AbhiPrasad AbhiPrasad merged commit 4678aac into develop Feb 12, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remove-extractTraceparentData branch February 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants