Skip to content

ref: Make scope setters on hub only write to isolation scope #10572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 8, 2024

Makes the global setX() functions only write to the isolation scope. Previously they wrote to both, the current scope, and the isolation scope, in the future we want these methods to only write to the isolation scope. Up until now this would have been breaking behaviour but now we can go through with it.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.14 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (-0.32% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.29 KB (-0.28% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.99 KB (-0.3% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.32 KB (-0.6% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.19 KB (-0.6% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (-0.6% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.19 KB (-0.61% 🔽)
@sentry/browser - Webpack (gzipped) 22.46 KB (-0.79% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.16 KB (-0.27% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.69 KB (-0.31% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.45 KB (-0.64% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.54 KB (-0.79% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.51 KB (-0.27% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.31 KB (-0.56% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.69 KB (-0.77% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.61 KB (-0.5% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.74 KB (-0.27% 🔽)
@sentry/react - Webpack (gzipped) 22.5 KB (-0.76% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.31 KB (-0.28% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 51.49 KB (-0.45% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.17 KB (-0.27% 🔽)

@lforst lforst marked this pull request as ready for review February 9, 2024 11:14
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad February 9, 2024 11:15
@lforst lforst merged commit a7097d9 into develop Feb 12, 2024
@lforst lforst deleted the lforst-scope-setters-hub-isolation branch February 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants