feat(core): Decouple metrics aggregation from client #10596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 16, 2024
This is a re-opening of #10596 which was closed automatically after the branch is was based off was closed. Part of the work for #10595 This PR decouples metrics aggregation from the client and stores the aggregator globally the first time it is required. This PR does not remove `captureAggregateMetrics` from the `BaseClient` or make `sendEnvelope` public as this can occur in a later PR. This will remove the remaining metrics code from the most basic tree-shaken Sentry configuration. The default (node) metrics implementation remains in `@sentry/core` because it's required for Deno and Vercel-Edge which don't ref. `@sentry/node`. There's a load of extra deletions and cleanup that can occur for v8 when the integration is deleted. For example `BrowserMetricsAggregator` can probably move to `@sentry/browser`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #10595
This PR decouples metrics aggregation from the client and stores the aggregator globally the first time it is required.
This PR does not remove
captureAggregateMetricsfrom theBaseClientor makesendEnvelopepublic as this can occur in a later PR. This will remove the remaining metrics code from the most basic tree-shaken Sentry configuration.The Node metrics implementation remains in
@sentry/corebecause it's required for Deno and Vercel-Edge which don't ref.@sentry/node.There's a load of extra deletions and cleanup that can occur for v8 when the integration is deleted. For example
BrowserMetricsAggregatorcan probably move to@sentry/browser.