Skip to content

feat(core): Update Sentry.addBreadcrumb to skip hub #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024

Build on top of #10600, as that relies on this to ensure replay still works.

This basically goes a step further than https://github.com/getsentry/sentry-javascript/pull/10586/files to actually change the implementation to skip the hub completely.

@mydea mydea requested review from lforst and Lms24 February 12, 2024 09:40
@mydea mydea self-assigned this Feb 12, 2024
Copy link
Contributor

github-actions bot commented Feb 12, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.89 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.12 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.05 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.74 KB (-0.31% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.31 KB (+0.11% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.16 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.17 KB (+0.04% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 22.44 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.88 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.23% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.38 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.48 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.64 KB (-0.27% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.19 KB (+0.16% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.6 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.62 KB (+0.23% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (-0.28% 🔽)
@sentry/react - Webpack (gzipped) 22.47 KB (+0.07% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.31 KB (-0.14% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.42 KB (+0.13% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (-0.07% 🔽)

Base automatically changed from fn/replayBreadcrumbsCapture to develop February 12, 2024 10:23
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to deleting the hub counterpart

@mydea mydea marked this pull request as ready for review February 12, 2024 10:23
Instead, just rely on the default behavior of having these on the isolation scope.
@mydea
Copy link
Member Author

mydea commented Feb 12, 2024

I've updated this to also fix/remove the custom handling for this in opentelemetry/node-experimental (which was the reason some tests failed etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants