Skip to content

feat(core): Update addEventProcessor to add to isolation scope #10606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024

Instead of to the client.
This was done to ensure this would be "global" without using the fully global event processors (which need to be removed in a separate step). But in the new model, it makes more sense to add them to the isolation scope.

Instead of to the client.
This was done to ensure this would be "global" without using the fully global event processors (which need to be removed in a separate step). But in the new model, it makes more sense to add them to the isolation scope.
@mydea mydea requested review from lforst and Lms24 February 12, 2024 11:01
@mydea mydea self-assigned this Feb 12, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.87 KB (-0.38% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.09 KB (-0.4% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.02 KB (-0.4% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.72 KB (-0.48% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.32% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.1 KB (-0.36% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (-0.25% 🔽)
@sentry/browser - Webpack (gzipped) 22.39 KB (-0.4% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.86 KB (-0.44% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.4 KB (-0.47% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.34 KB (-0.4% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.45 KB (-0.46% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.39 KB (-0.61% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.94 KB (-0.53% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.35 KB (-0.69% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.52 KB (-0.33% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.47 KB (-0.42% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (-0.36% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.22 KB (-0.37% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.32 KB (-0.21% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (-0.55% 🔽)

@mydea mydea merged commit 93db2dc into develop Feb 12, 2024
@mydea mydea deleted the fn/addEventProcessor branch February 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants