Skip to content

feat(v8): Remove span.toTraceparent method #10698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

ref #10677

@AbhiPrasad AbhiPrasad requested a review from a team February 16, 2024 20:08
@AbhiPrasad AbhiPrasad self-assigned this Feb 16, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 and removed request for a team February 16, 2024 20:08
Copy link
Contributor

github-actions bot commented Feb 16, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.78 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.03 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.54 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.24 KB (-0.03% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.14 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.41 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.02 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.53 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.49 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.28 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.87 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.79 KB (-0.04% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.34 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.82 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.05 KB (-0.03% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 20, 2024 15:07
@AbhiPrasad
Copy link
Member Author

devDependencies:
+ @sentry/rollup-plugin 2.14.1
+ rollup 4.0.2 (4.12.0 is available)
+ vitest 0.34.6 (1.3.1 is available)

Done in 4.3s
Progress: resolved 215, reused 0, downloaded 165, added 165, done

> [email protected] build /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps
> rollup --config rollup.config.mjs


./src/app.js → ./dist/app.js...
[sentry-rollup-plugin] Info: Sending error and performance telemetry data to Sentry. To disable telemetry, set `options.telemetry` to `false`.
[!] (plugin sentry-rollup-debug-id-upload-plugin) TypeError: uploadSpan.toTraceparent is not a function
    at _callee3$ (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/src/debug-id-upload.ts:156:40)
    at tryCatch (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/dist/esm/index.mjs:83:17)
    at Generator.<anonymous> (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/dist/esm/index.mjs:164:22)
    at Generator.next (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/dist/esm/index.mjs:108:21)
    at asyncGeneratorStep (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/dist/esm/index.mjs:354:24)
    at _next (file:///home/runner/work/sentry-javascript/sentry-javascript/dev-packages/e2e-tests/test-applications/debug-id-sourcemaps/node_modules/.pnpm/@[email protected]/node_modules/@sentry/bundler-plugin-core/dist/esm/index.mjs:373:9)

oof

@AbhiPrasad AbhiPrasad merged commit c4acfe9 into develop Feb 21, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-toTraceparent branch February 21, 2024 17:36
AbhiPrasad added a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants