feat(performance): Adds exclusive time and measurements to spans

packages/core/src/semanticAttributes.ts

@@ -19,3 +19,8 @@ export const SEMANTIC_ATTRIBUTE_SENTRY_OP = 'sentry.op';
  * Use this attribute to represent the origin of a span.
  */
 export const SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN = 'sentry.origin';
+
+/**
+ * Use this attribute to represent measurements of a span.
+ */
+export const SEMANTIC_ATTRIBUTE_MEASUREMENTS = 'measurements';

packages/core/src/tracing/span.ts

@@ -1,6 +1,7 @@
 /* eslint-disable max-lines */
 import type {
   Instrumenter,
+  Measurements,
   Primitive,
   Span as SpanInterface,
   SpanAttributeValue,
@@ -17,7 +18,11 @@ import { dropUndefinedKeys, logger, timestampInSeconds, uuid4 } from '@sentry/ut
 
 import { DEBUG_BUILD } from '../debug-build';
 import { getMetricSummaryJsonForSpan } from '../metrics/metric-summary';
-import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '../semanticAttributes';
+import {
+  SEMANTIC_ATTRIBUTE_MEASUREMENTS,
+  SEMANTIC_ATTRIBUTE_SENTRY_OP,
+  SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
+} from '../semanticAttributes';
 import { getRootSpan } from '../utils/getRootSpan';
 import {
   TRACE_FLAG_NONE,
@@ -115,6 +120,7 @@ export class Span implements SpanInterface {
   protected _endTime?: number;
   /** Internal keeper of the status */
   protected _status?: SpanStatusType | string;
+  protected _exclusiveTime?: number;
 
   private _logMessage?: string;
 
@@ -159,6 +165,9 @@ export class Span implements SpanInterface {
     if (spanContext.endTimestamp) {
       this._endTime = spanContext.endTimestamp;
     }
+    if (spanContext.exclusiveTime) {
+      this._exclusiveTime = spanContext.exclusiveTime;
+    }
   }
 
   // This rule conflicts with another eslint rule :(
@@ -626,6 +635,8 @@ export class Span implements SpanInterface {
       trace_id: this._traceId,
       origin: this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
       _metrics_summary: getMetricSummaryJsonForSpan(this),
+      exclusive_time: this._exclusiveTime,
+      measurements: this._attributes[SEMANTIC_ATTRIBUTE_MEASUREMENTS] as Measurements | undefined,
     });
   }
 

packages/core/test/lib/tracing/span.test.ts

@@ -105,9 +105,6 @@ describe('span', () => {
     it('disallows invalid attribute types', () => {
       const span = new Span();
 
-      /** @ts-expect-error this is invalid */
-      span.setAttribute('str', {});
-
       /** @ts-expect-error this is invalid */
       span.setAttribute('str', null);
 

packages/types/src/span.ts

@@ -1,5 +1,6 @@
 import type { TraceContext } from './context';
 import type { Instrumenter } from './instrumenter';
+import type { Measurements } from './measurement';
 import type { Primitive } from './misc';
 import type { HrTime } from './opentelemetry';
 import type { Transaction } from './transaction';
@@ -21,13 +22,15 @@ export type SpanAttributeValue =
   | boolean
   | Array<null | undefined | string>
   | Array<null | undefined | number>
-  | Array<null | undefined | boolean>;
+  | Array<null | undefined | boolean>
+  | Measurements;
 
 export type SpanAttributes = Partial<{
   'sentry.origin': string;
   'sentry.op': string;
   'sentry.source': string;
   'sentry.sample_rate': number;
+  measurements: Measurements;
 }> &
   Record<string, SpanAttributeValue | undefined>;
 
@@ -178,6 +181,11 @@ export interface SpanContext {
    * The origin of the span, giving context about what created the span.
    */
   origin?: SpanOrigin;
+
+  /**
+   * Exclusive time in milliseconds.
+   */
+  exclusiveTime?: number;
 }
 
 /** Span holding trace_id, span_id */