Skip to content

ref: Refactor remaining makeMain usage #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2024
Merged

ref: Refactor remaining makeMain usage #10713

merged 2 commits into from
Feb 19, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 19, 2024

Instead, use a combination of setCurrentClient() and client.init().

I also refactored the domain ACS to avoid using the hub on the carrier (removing this overall will happen in a follow up PR).

I also removed the tracing hub test as that should be covered in other places and uses a lot of internal hub stuff etc.

@mydea mydea requested a review from lforst February 19, 2024 08:56
@mydea mydea self-assigned this Feb 19, 2024
@mydea mydea force-pushed the fn/remove-hub-global branch from 222ed72 to b76ef3c Compare February 19, 2024 09:59
Copy link
Contributor

github-actions bot commented Feb 19, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.89 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.17 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.1 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.75 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.36 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.26 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.23 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.24 KB (0%)
@sentry/browser - Webpack (gzipped) 22.49 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.76 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.7 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.8 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.19 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.81 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.31 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.94 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (0%)
@sentry/react - Webpack (gzipped) 22.52 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.98 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.19 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.22 KB (0%)

@mydea mydea force-pushed the fn/remove-hub-global branch from 558d121 to bfdaa92 Compare February 19, 2024 11:08
@mydea
Copy link
Member Author

mydea commented Feb 19, 2024

OK, we can't remove this yet, as vite-plugin v0.6 uses this, which breaks sveltekit tests (which pulls this in and uses this...) and bumping vite-plugins is not that trivial. So I'll instead refactor this to be a noop for now, then once we bumped vite-plugin we can fully remove this.

@mydea mydea changed the title ref: Remove makeMain export ref: Refactor remaining makeMain usage Feb 19, 2024
@mydea mydea merged commit 7dfa746 into develop Feb 19, 2024
@mydea mydea deleted the fn/remove-hub-global branch February 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants