ref: Collect child spans references via non-enumerable on Span object #10715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
changed the title
added 3 commits
February 19, 2024 12:09
mydea
reviewed
Feb 19, 2024
| @@ -401,6 +402,8 @@ export class SentrySpan implements SpanInterface { | |||
| childSpan.spanRecorder.add(childSpan); | |||
| } | |||
|
|
|||
| addChildSpanReferenceToSpan(childSpan, this); | |||
There was a problem hiding this comment.
l: nit, but I think I would prefer an order of parent, child, for the arguments 🤔 Makes it a bit easier to reason about IMHO... also the reference is a bit redundant here I'd say, what about:
addChildSpanToSpan(span, childSpan);but no strong feelings, I'm also OK with what is currently here!
mydea
reviewed
Feb 20, 2024
| @@ -401,6 +402,8 @@ export class SentrySpan implements SpanInterface { | |||
| childSpan.spanRecorder.add(childSpan); | |||
| } | |||
|
|
|||
| addChildSpanToSpan(this, childSpan); | |||
There was a problem hiding this comment.
Suggested change
| addChildSpanToSpan(this, childSpan); | |
| // For now, we capture this here as well in order to ensure backwards compatibility | |
| // eventually this will only be captured in `startSpan` methods | |
| addChildSpanToSpan(this, childSpan); |
mydea
approved these changes
Feb 20, 2024
packages/core/src/tracing/trace.ts
Outdated
| export function getSpanTree(span: SpanWithPotentialChildren): Span[] { | ||
| const resultSet = new Set<Span>(); | ||
|
|
||
| function recurse(span: SpanWithPotentialChildren): void { |
There was a problem hiding this comment.
Suggested change
| function recurse(span: SpanWithPotentialChildren): void { | |
| function addSpanChildren(span: SpanWithPotentialChildren): void { |
I'd name this a bit more expressively here?
packages/core/src/tracing/trace.ts
Outdated
| resultSet.add(span); | ||
| const childSpans = span[CHILD_SPANS_FIELD] ? Array.from(span[CHILD_SPANS_FIELD]) : []; | ||
| for (const childSpan of childSpans) { | ||
| recurse(childSpan); |
There was a problem hiding this comment.
Suggested change
| recurse(childSpan); | |
| addSpanChildren(childSpan); |
packages/core/src/tracing/trace.ts
Outdated
| } | ||
| } | ||
|
|
||
| recurse(span); |
There was a problem hiding this comment.
Suggested change
| recurse(span); | |
| addSpanChildren(span); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on a transactions span recorder when starting spans we are tracking child spans via a non-enumerable on the parent span.