Skip to content

feat(integrations): Capture error arguments as exception regardless of level in captureConsoleIntegration #10744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

GingerAdonis
Copy link
Contributor

This change allows console.warn(new Error('Hello')) (and other severity levels) to be captured as an exception instead of a message. This was already the case for console.error.

Discussed this PR with @lforst on Discord.

@mydea mydea changed the title feat(node): always send captured console errors as exceptions feat(integrations): always send captured console errors as exceptions Feb 20, 2024
@GingerAdonis
Copy link
Contributor Author

Thanks for the title change. Got confused there as I was also working on a custom node integration.

@GingerAdonis GingerAdonis changed the title feat(integrations): always send captured console errors as exceptions feat(integrations): always capture console Error as exception regardless of level Feb 20, 2024
@AbhiPrasad
Copy link
Member

I guess this is a breaking change, so we can release it as part of v8.

@lforst lforst changed the title feat(integrations): always capture console Error as exception regardless of level feat(integrations): Capture error arguments as exception regardless of level in captureConsoleIntegration Feb 20, 2024
@lforst lforst changed the base branch from master to develop February 20, 2024 17:42
Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AbhiPrasad AbhiPrasad added this to the 8.0.0 milestone Feb 20, 2024
@lforst lforst merged commit f84d3b9 into getsentry:develop Feb 21, 2024
AbhiPrasad pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants