Skip to content

ref(node-experimental): Rename errorHandler to expressErrorHandler #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 20, 2024

Also provide a new setupExpressErrorHandler(app) utility.

@mydea mydea requested review from lforst and AbhiPrasad February 20, 2024 14:31
@mydea mydea self-assigned this Feb 20, 2024
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a migration note. Sorry it doesn't, this is node experimental 😅

Copy link
Contributor

github-actions bot commented Feb 20, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.97 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.52 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.24 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.14 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.14 KB (0%)
@sentry/browser - Webpack (gzipped) 22.4 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.03 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.53 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.68 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.29 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.81 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.79 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (0%)
@sentry/react - Webpack (gzipped) 22.43 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.82 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.06 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@mydea
Copy link
Member Author

mydea commented Feb 20, 2024

Yeah for the node package we'll need more in-depth migration guides anyhow 😬 as there a lot will change (but mostly it will mean removing code you don't need anymore).

@mydea mydea force-pushed the fn/renameErrorHandler branch from 73c8579 to f25d367 Compare February 21, 2024 08:07
Also provide a new `setupExpressErrorHandler(app)` utility.
@mydea mydea force-pushed the fn/renameErrorHandler branch from f25d367 to 5c236e7 Compare February 21, 2024 08:24
@mydea mydea merged commit f014ac6 into develop Feb 21, 2024
@mydea mydea deleted the fn/renameErrorHandler branch February 21, 2024 09:06
AbhiPrasad pushed a commit that referenced this pull request Feb 21, 2024
#10746)

Also provide a new `setupExpressErrorHandler(app)` utility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants