ref: Cleanup browser profiling integration #10766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Feb 21, 2024
This does two things: 1. Remove the deprecated class-based `BrowserProfilingIntegration` 2. Remove the `onProfilingStartRouteTransaction` method - this shouldn't be needed anymore, as now the execution order of browser tracing is ensured to be after browser profiling, ensuring that we had the chance to register the `startTransaction` hook before browser tracing started a transaction (as that now runs in `afterAllSetup`)
mydea
force-pushed
the
fn/browser-profiling
branch
from
81b82b1 to
16baa7b
Compare
size-limit report 📦
|
|
I'm going to merge this in because it changes stuff with |
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 21, 2024
This does two things: 1. Remove the deprecated class-based `BrowserProfilingIntegration` 2. Remove the `onProfilingStartRouteTransaction` method - this shouldn't be needed anymore, as now the execution order of browser tracing is ensured to be after browser profiling, ensuring that we had the chance to register the `startTransaction` hook before browser tracing started a transaction (as that now runs in `afterAllSetup`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two things:
BrowserProfilingIntegrationonProfilingStartRouteTransactionmethod - this shouldn't be needed anymore, as now the execution order of browser tracing is ensured to be after browser profiling, ensuring that we had the chance to register thestartTransactionhook before browser tracing started a transaction (as that now runs inafterAllSetup)