docs(v8): Restructure migration docs #10830
Conversation
AbhiPrasad
requested review from
stephanie-anderson and
s1gr1d
and removed request for
a team
AbhiPrasad
force-pushed
the
abhi-migration-docs-v8
branch
2 times, most recently
from
8fae36f to
3b7af66
Compare
MIGRATION.md
Outdated
| `['localhost', /^\/(?!\/)/]`. This meant that all request targets to that had "localhost" in the URL, or started with a | ||
| `/` were equipped with tracing headers. This default was chosen to prevent CORS errors in your browser applications. | ||
| However, this default had a few flaws. | ||
| **Node.js**: We now official support Node 14+ for our CJS package, and Node 18.8+ for our ESM package. This applies to |
There was a problem hiding this comment.
Actually let's make this 14.8+ as this is what supports async local storage! (I'll also bump the actual engines for this)
MIGRATION.md
Outdated
|
|
||
| ## Removal of the `tracingOrigins` option | ||
| For IE11 support please transpile your code to ES% using babel or similar and add required polyfills. |
There was a problem hiding this comment.
| For IE11 support please transpile your code to ES% using babel or similar and add required polyfills. | |
| For IE11 support please transpile your code to ES5 using babel or similar and add required polyfills. |
|
|
||
| `@sentry/hub` has been removed. All exports from `@sentry/tracing` should be available in `@sentry/core` or in | ||
| `@sentry/browser` and `@sentry/node`. | ||
| Sentry.addTracingExtensions(); |
There was a problem hiding this comment.
do we need this if we add browser tracing below?
There was a problem hiding this comment.
copy paste error - fixed!
There was a problem hiding this comment.
Great improvement! Also thx for splitting up the various version migrations into their own files!
I think for a stable version we should more clearly outline which changes apply to all SDKs vs. to specific SDKs. Maybe what would help here in general is some kind of index/table of content on the top because this migration guide is just so damn long 😅
(Alternatively a "How to read this guide" section where we explain what users should read)
MIGRATION.md
Outdated
|
|
||
| ## Removal of `Sentry.configureScope` (#10565) | ||
| ```js | ||
| // Before |
There was a problem hiding this comment.
super-l: doesn't have to happen now but for clarity, we could label the changes as v7/v8 vs. before/after?
MIGRATION.md
Outdated
| integrations: [Sentry.browserTracingIntegration()], | ||
| }); | ||
|
|
||
| // You still need to add the Trace Service like before! |
There was a problem hiding this comment.
l:
| // You still need to add the Trace Service like before! | |
| // You still need to add the TraceService like before! |
AbhiPrasad
force-pushed
the
abhi-migration-docs-v8
branch
from
3b7af66 to
f2c6378
Compare
This is an attempt to restructure our migration docs in preparation for the first alpha.