Skip to content

feat(node): Remove unnecessary URL imports #10860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/node-experimental/src/integrations/anr/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { URL } from 'url';
import { defineIntegration, getCurrentScope } from '@sentry/core';
import type { Contexts, Event, EventHint, IntegrationFn } from '@sentry/types';
import { logger } from '@sentry/utils';
Expand Down
1 change: 0 additions & 1 deletion packages/node-experimental/src/integrations/spotlight.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as http from 'http';
import { URL } from 'url';
import { defineIntegration } from '@sentry/core';
import type { Client, Envelope, IntegrationFn } from '@sentry/types';
import { logger, serializeEnvelope } from '@sentry/utils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
// https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c73060bd14bb74a2f1906ccfc714d385863bc07d/types/boom/v4/index.d.ts

import type * as stream from 'stream';
import type * as url from 'url';

interface Podium {
new (events?: Events[]): Podium;
Expand Down Expand Up @@ -214,7 +213,7 @@ interface Request extends Podium {
readonly path: string;
response: ResponseObject | Boom | null;
readonly route: RequestRoute;
readonly url: url.Url;
readonly url: URL;
}

interface ResponseObjectHeaderOptions {
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/proxy/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
import * as http from 'http';
import * as https from 'https';
import type { Readable } from 'stream';
// TODO (v8): Remove this when Node < 12 is no longer supported
import type { URL } from 'url';

export type ThenableRequest = http.ClientRequest & {
then: Promise<http.IncomingMessage>['then'];
Expand Down
2 changes: 0 additions & 2 deletions packages/node-experimental/src/proxy/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ import type * as http from 'http';
import type { OutgoingHttpHeaders } from 'http';
import * as net from 'net';
import * as tls from 'tls';
// TODO (v8): Remove this when Node < 12 is no longer supported
import { URL } from 'url';
import { logger } from '@sentry/utils';
import { Agent } from './base';
import type { AgentConnectOpts } from './base';
Expand Down
1 change: 0 additions & 1 deletion packages/node-experimental/src/transports/http-module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { ClientRequest, IncomingHttpHeaders, RequestOptions as HTTPRequestOptions } from 'http';
import type { RequestOptions as HTTPSRequestOptions } from 'https';
import type { URL } from 'url';

export type HTTPModuleRequestOptions = HTTPRequestOptions | HTTPSRequestOptions | string | URL;

Expand Down
1 change: 0 additions & 1 deletion packages/node-experimental/src/transports/http.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as http from 'http';
import * as https from 'https';
import { Readable } from 'stream';
import { URL } from 'url';
import { createGzip } from 'zlib';
import { createTransport } from '@sentry/core';
import type {
Expand Down