ref(deno): Remove @sentry/browser dependency from @sentry/deno
#10867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Feb 29, 2024
| * This breadcrumbsIntegration is almost the same as the one from @sentry/browser. | ||
| * The Deno-version does not support browser-specific APIs like dom, xhr and history. | ||
| */ | ||
| const _breadcrumbsIntegration = ((options: Partial<BreadcrumbsOptions> = {}) => { |
There was a problem hiding this comment.
l: Let's move the docstring from here to export const breadcrumbsIntegration so it shows up in user's IDEs.
size-limit report 📦
|
timfish
approved these changes
Feb 29, 2024
s1gr1d
force-pushed
the
sig-delete-browser-dep-in-deno
branch
from
e6fc01f to
05b1276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the breadcrumbsIntegration (without xhr, dom, history) to deno without importing that from browser.