Skip to content

test(node): Use different test server ports for node and node-experimental packages #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Mar 15, 2024

Fingers crossed.

Fixes #11111

Node and node-experimental used the same port to set up a test-server. I believe it may have flaked depending on whether the tests were ran at the same time or not.

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we maybe randomize them, I wonder? Or let them pick a free one...

@lforst
Copy link
Contributor Author

lforst commented Mar 15, 2024

LGTM, can we maybe randomize them, I wonder? Or let them pick a free one...

Absolutely, just wanted to fix this pragmatically because it is annoying as hell.

@lforst lforst merged commit 7466a52 into develop Mar 15, 2024
@lforst lforst deleted the lforst-unflake-nod-tests branch March 15, 2024 09:17
@lforst
Copy link
Contributor Author

lforst commented Mar 15, 2024

First try succeeded. I am merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: makeNewHttpsTransport() › .send() › should correctly send envelope to server
2 participants