Skip to content

feat(node): Do not include prismaIntegration by default #11265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat(node): Do not include prismaIntegration by default #11265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45bd0a8
feat(node): Do not include `prismaIntegration` by default
mydea Mar 25, 2024
ef76a02
fix test
mydea Mar 25, 2024
ff91073
fix linting
mydea Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-packages/node-integration-tests/suites/tracing-experimental/prisma-orm/scenario.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Sentry.init({
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
integrations: [Sentry.prismaIntegration()],
});

// Stop the process from exiting before the transaction is sent
Expand Down
4 changes: 0 additions & 4 deletions packages/astro/src/server/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { applySdkMetadata } from '@sentry/core';
import type { NodeOptions } from '@sentry/node';
import { getDefaultIntegrations } from '@sentry/node';
import { init as initNodeSdk, setTag } from '@sentry/node';

/**
Expand All @@ -10,9 +9,6 @@ import { init as initNodeSdk, setTag } from '@sentry/node';
export function init(options: NodeOptions): void {
const opts = {
...options,
// TODO v8: For now, we disable the Prisma integration, because that has weird esm-cjs interop issues
// We should figure these out and fix these before v8 goes stable.
defaultIntegrations: getDefaultIntegrations(options).filter(integration => integration.name !== 'Prisma'),
};
applySdkMetadata(opts, 'astro', ['astro', 'node']);

Expand Down
6 changes: 4 additions & 2 deletions packages/node-experimental/src/integrations/tracing/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { mysqlIntegration } from './mysql';
import { mysql2Integration } from './mysql2';
import { nestIntegration } from './nest';
import { postgresIntegration } from './postgres';
import { prismaIntegration } from './prisma';

/**
* With OTEL, all performance integrations will be added, as OTEL only initializes them when the patched package is actually required.
Expand All @@ -26,7 +25,10 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mysqlIntegration(),
mysql2Integration(),
postgresIntegration(),
prismaIntegration(),
// For now, we do not include prisma by default because it has ESM issues
// See https://github.com/prisma/prisma/issues/23410
// TODO v8: Figure out a better solution for this, maybe only disable in ESM mode?
// prismaIntegration(),
nestIntegration(),
hapiIntegration(),
koaIntegration(),
Expand Down