Skip to content

ref: Move node & node-experimental folders #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2024
Merged

ref: Move node & node-experimental folders #11309

merged 3 commits into from
Mar 27, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 27, 2024

Now, the "new" node is in packages/node, while @sentry/node-experimental (the "old" node) is in packages/node-experimental

In a next step we can look into actually removing node-experimental (it is only used/referenced in tests anymore).

We should also add this commit to .git-blame-ignore-revs in a follow up.

Now, the "new" node is in `packages/node`, while `@sentry/node-experimental` (the "old" node) is in `packages/node-experimental`
@mydea mydea requested review from lforst and AbhiPrasad March 27, 2024 13:37
@mydea mydea self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Bundle Report

Changes will decrease total bundle size by 1.19MB ⬇️

Bundle name Size Change
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/node-experimental-cjs 157.11kB 0 bytes
@sentry/node-cjs 337.26kB 0 bytes
@sentry/node-experimental-esm 150.43kB 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/node-esm 333.86kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes
@sentry/aws-serverless-cjs 20.29kB 5.67kB ⬆️
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/bun-cjs 13.5kB 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/google-cloud-serverless-cjs 23.0kB 0 bytes
@sentry/bun-esm 10.05kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/google-cloud-serverless-esm 19.16kB 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry/opentelemetry-esm (removed) 70.52kB ⬇️
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry-internal/tracing-esm (removed) 107.23kB ⬇️
@sentry-internal/replay-esm (removed) 306.29kB ⬇️
@sentry-internal/replay-cjs (removed) 306.18kB ⬇️
@sentry/browser-esm (removed) 104.35kB ⬇️
@sentry/browser-cjs (removed) 107.15kB ⬇️
@sentry/wasm-esm (removed) 4.85kB ⬇️
@sentry-internal/replay-canvas-esm (removed) 29.34kB ⬇️
@sentry/svelte-cjs (removed) 13.84kB ⬇️
@sentry/gatsby-cjs (removed) 905 bytes ⬇️
@sentry/react-cjs (removed) 45.04kB ⬇️
@sentry/svelte-esm (removed) 12.72kB ⬇️
@sentry/react-esm (removed) 41.18kB ⬇️
@sentry/wasm-cjs (removed) 5.2kB ⬇️
@sentry/gatsby-esm (removed) 385 bytes ⬇️
@sentry/vue-cjs (removed) 20.19kB ⬇️
@sentry/vue-esm (removed) 18.85kB ⬇️

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.46 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.8 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.6 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.35 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing) 36.63 KB (-0.23% 🔽)
@sentry/browser (incl. browserTracingIntegration) 36.63 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackIntegration) 31.38 KB (0%)
@sentry/browser (incl. feedbackModalIntegration) 31.5 KB (0%)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.51 KB (0%)
@sentry/browser (incl. sendFeedback) 27.45 KB (0%)
@sentry/browser 22.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.72 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing) 36.26 KB (-0.25% 🔽)
CDN Bundle 23.97 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.89 KB (-0.11% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 109.45 KB (-0.21% 🔽)
CDN Bundle - uncompressed 70.94 KB (0%)
@sentry/react (incl. Tracing, Replay) 71.78 KB (-0.12% 🔽)
@sentry/react 22.64 KB (0%)

@mydea mydea merged commit c88ff46 into develop Mar 27, 2024
@mydea mydea deleted the fn/rename-node-dirs branch March 27, 2024 14:18
mydea added a commit that referenced this pull request Mar 27, 2024
mydea added a commit that referenced this pull request Mar 27, 2024
Reverts #11309

Reverting this so we can merge master into develop 😬 will add this
afterwards again...
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Now, the "new" node is in `packages/node`, while
`@sentry/node-experimental` (the "old" node) is in
`packages/node-experimental`

In a next step we can look into actually removing `node-experimental`
(it is only used/referenced in tests anymore).

We should also add this commit to `.git-blame-ignore-revs` in a follow
up.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
)

Reverts getsentry#11309

Reverting this so we can merge master into develop 😬 will add this
afterwards again...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants