Skip to content

test(node): All integration tests now use the new runner #11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2024
Merged

test(node): All integration tests now use the new runner #11341

merged 2 commits into from
Mar 28, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 28, 2024 •
edited
Loading

This PR converts the remaining tests to using the newer child process runner.

Because the test scenarios are now completely isolated, Jest can be used to run them rather than the custom script.

@timfish timfish changed the title test(node): All integration test using new runner test(node): All integration tests now use the new runner Mar 28, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 7.49kB ⬆️

Bundle name Size Change
@sentry/types-cjs 35 bytes 0 bytes
@sentry-internal/integration-shims-cjs 3.65kB 0 bytes
@sentry/vercel-edge-cjs 18.23kB 0 bytes
@sentry-internal/feedback-esm 65.5kB 0 bytes
@sentry/opentelemetry-esm 67.4kB 0 bytes
@sentry-internal/tracing-esm 107.26kB 0 bytes
@sentry-internal/replay-cjs 306.35kB 0 bytes
@sentry/types-esm 35 bytes 0 bytes
@sentry/node-cjs 336.97kB 0 bytes
@sentry-internal/integration-shims-esm 2.99kB 0 bytes
@sentry/node-esm 333.56kB 0 bytes
@sentry/utils-cjs 178.75kB 0 bytes
@sentry/utils-esm 174.17kB 0 bytes
@sentry-internal/replay-esm 306.46kB 0 bytes
@sentry/bun-cjs 13.5kB 0 bytes
@sentry-internal/feedback-cjs 65.81kB 0 bytes
@sentry/browser-cjs 107.36kB 0 bytes
@sentry/bun-esm 10.05kB 0 bytes
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/wasm-cjs 5.2kB 0 bytes
@sentry/aws-serverless-cjs 14.62kB 0 bytes
@sentry/svelte-esm 12.72kB 0 bytes
@sentry-internal/replay-canvas-cjs 29.51kB 0 bytes
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/google-cloud-serverless-cjs 23.0kB 0 bytes
@sentry/browser-esm 104.53kB 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/nextjs-esm 20.02kB 7.49kB ⬆️
@sentry/vue-esm 18.85kB 0 bytes
@sentry-internal/replay-canvas-esm 29.43kB 0 bytes
@sentry/google-cloud-serverless-esm 19.16kB 0 bytes
@sentry/react-esm 41.18kB 0 bytes
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/vercel-edge-esm 16.13kB 0 bytes
@sentry/opentelemetry-cjs 68.45kB 0 bytes
@sentry/core-cjs 240.44kB 0 bytes
@sentry/react-cjs 45.04kB 0 bytes
@sentry-internal/tracing-cjs 108.01kB 0 bytes
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/core-esm 236.82kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes

@timfish timfish marked this pull request as ready for review March 28, 2024 17:56
@timfish timfish force-pushed the timfish/node-tests-new-runner branch from 215459c to fab0b47 Compare March 28, 2024 19:15
@timfish timfish requested review from AbhiPrasad and mydea March 28, 2024 20:26
AbhiPrasad
AbhiPrasad approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@AbhiPrasad AbhiPrasad merged commit 0889751 into develop Mar 28, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/node-tests-new-runner branch March 28, 2024 21:21
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@timfish @cadesalaberry
test(node): All integration tests now use the new runner (getsentry#1…
6febd7d 
…1341)

This PR converts the remaining tests to using the newer child process
runner.

Because the test scenarios are now completely isolated, Jest can be used
to run them rather than the custom script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad