Skip to content

test(e2e): Make proxy server more error resistant #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Apr 24, 2024

No description provided.

@lforst lforst requested review from mydea and Lms24 April 24, 2024 08:43
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is because of the CI flakes/fails we encountered yesterday?

// eslint-disable-next-line no-console
console.log(
'[event-proxy-server] Warn: No dsn on envelope header. Maybe a client-report was received. Proxy request body:',
proxyRequestBody,

Check warning

Code scanning / CodeQL

Log injection

Log entry depends on a [user-provided value](1).
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (added)
@sentry/browser (incl. Tracing) 32.63 KB (added)
@sentry/browser (incl. Tracing, Replay) 67.97 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.37 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.02 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.21 KB (added)
@sentry/browser (incl. Feedback) 37.76 KB (added)
@sentry/browser (incl. sendFeedback) 26.43 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.91 KB (added)
@sentry/react 24.33 KB (added)
@sentry/react (incl. Tracing) 35.53 KB (added)
@sentry/vue 25.26 KB (added)
@sentry/vue (incl. Tracing) 34.38 KB (added)
@sentry/svelte 21.77 KB (added)
CDN Bundle 23.95 KB (added)
CDN Bundle (incl. Tracing) 33.89 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.61 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.44 KB (added)
CDN Bundle - uncompressed 70.56 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 100.57 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.18 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.49 KB (added)
@sentry/nextjs (client) 34.75 KB (added)
@sentry/sveltekit (client) 33.13 KB (added)
@sentry/node 152.84 KB (added)

@lforst
Copy link
Contributor Author

lforst commented Apr 24, 2024

I guess this is because of the CI flakes/fails we encountered yesterday?

Yea. I am not sure whether this will actually fix things but some extra logging can't hurt to know why exactly no dsn is there.

@lforst lforst merged commit e88968f into develop Apr 24, 2024
@lforst lforst deleted the lforst-make-e2e-proxy-more-error-resistant branch April 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants