Skip to content

ref(otel): Remove mentions of hub from comments #12170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024
Merged

ref(otel): Remove mentions of hub from comments #12170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/opentelemetry/src/contextManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { getScopesFromContext, setContextOnScope, setScopesOnContext } from './u
import { setIsSetup } from './utils/setupCheck';

/**
* Wrap an OpenTelemetry ContextManager in a way that ensures the context is kept in sync with the Sentry Hub.
* Wrap an OpenTelemetry ContextManager in a way that ensures the context is kept in sync with the Sentry Scope.
*
* Usage:
* import { AsyncLocalStorageContextManager } from '@opentelemetry/context-async-hooks';
Expand All @@ -23,7 +23,7 @@ export function wrapContextManagerClass<ContextManagerInstance extends ContextMa
): typeof ContextManagerClass {
/**
* This is a custom ContextManager for OpenTelemetry, which extends the default AsyncLocalStorageContextManager.
* It ensures that we create a new hub per context, so that the OTEL Context & the Sentry Hub are always in sync.
* It ensures that we create new scopes per context, so that the OTEL Context & the Sentry Scope are always in sync.
*
* Note that we currently only support AsyncHooks with this,
* but since this should work for Node 14+ anyhow that should be good enough.
Expand All @@ -37,7 +37,7 @@ export function wrapContextManagerClass<ContextManagerInstance extends ContextMa
}
/**
* Overwrite with() of the original AsyncLocalStorageContextManager
* to ensure we also create a new hub per context.
* to ensure we also create new scopes per context.
*/
public with<A extends unknown[], F extends (...args: A) => ReturnType<F>>(
context: Context,
Expand Down
Loading