-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(browser): Fix parenthesis parsing logic for chromium #12373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -579,6 +579,7 @@ describe('Tracekit - Chrome Tests', () => { | |
name: 'Error', | ||
stack: `Error: bad | ||
at something (http://localhost:5000/(some)/(thing)/index.html:20:16) | ||
at http://localhost:5000/(group)/[route]/script.js:1:126 | ||
at more (http://localhost:5000/(some)/(thing)/index.html:25:7)`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this could be passed?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had the same thought but chrome doesn't emit such frames I think. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We haven't seen stack lines like that. They only appear to be surrounded in parenthesis when there is filename. |
||
}; | ||
|
||
|
@@ -596,6 +597,13 @@ describe('Tracekit - Chrome Tests', () => { | |
colno: 7, | ||
in_app: true, | ||
}, | ||
{ | ||
filename: 'http://localhost:5000/(group)/[route]/script.js', | ||
function: '?', | ||
lineno: 1, | ||
colno: 126, | ||
in_app: true, | ||
}, | ||
{ | ||
filename: 'http://localhost:5000/(some)/(thing)/index.html', | ||
function: 'something', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a comment here for what this would match, as an example? makes it easier to follow this than to try to parse the regex 😅