Skip to content

fix(browser): Handle more edge cases with INP #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 6, 2024

This is a PR adjusting #12372 to keep transaction name for INP even if the route has changed in the meanwhile.

Now, we keep a map of the last 10 interactionId <> route names, which we use instead (if possible).

@mydea mydea self-assigned this Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size
@sentry/browser 21.74 KB (added)
@sentry/browser (incl. Tracing) 32.91 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.49 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.81 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.55 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.67 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.53 KB (added)
@sentry/browser (incl. metrics) 25.92 KB (added)
@sentry/browser (incl. Feedback) 37.89 KB (added)
@sentry/browser (incl. sendFeedback) 26.32 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.86 KB (added)
@sentry/react 24.51 KB (added)
@sentry/react (incl. Tracing) 35.96 KB (added)
@sentry/vue 25.73 KB (added)
@sentry/vue (incl. Tracing) 34.76 KB (added)
@sentry/svelte 21.87 KB (added)
CDN Bundle 23.11 KB (added)
CDN Bundle (incl. Tracing) 34.64 KB (added)
CDN Bundle (incl. Tracing, Replay) 68.58 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.75 KB (added)
CDN Bundle - uncompressed 68 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 102.57 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212.46 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.93 KB (added)
@sentry/nextjs (client) 35.3 KB (added)
@sentry/sveltekit (client) 33.55 KB (added)
@sentry/node 115.24 KB (added)
@sentry/node - without tracing 94.55 KB (added)
@sentry/aws-serverless 103.72 KB (added)

@mydea mydea force-pushed the fn/inp-improvements branch from ab0e012 to 48851e6 Compare June 6, 2024 12:54
@mydea mydea merged commit 489b950 into fn/web-vitals-inp Jun 6, 2024
101 of 102 checks passed
@mydea mydea deleted the fn/inp-improvements branch June 6, 2024 14:33
mydea added a commit that referenced this pull request Jun 7, 2024
This is a PR adjusting
#12372 to keep
transaction name for INP even if the route has changed in the meanwhile.

Now, we keep a map of the last 10 interactionId <> route names, which we
use instead (if possible).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants