Skip to content

meta(changelog): Update changelog for 8.10.0 #12542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
1a2a1f4
Merge pull request #12474 from getsentry/master
github-actions[bot] Jun 12, 2024
e09b93a
build: Add `tsconfig.json` to test directories to fix VSCode (#12475)
mydea Jun 12, 2024
b2bdf1a
feat(profiling) add global profile context while profiler is running …
JonasBa Jun 12, 2024
f032f3f
fix(node): Ensure status is correct for http server span errors (#12477)
mydea Jun 12, 2024
60dad34
ci: Add workflow to automatically add external contributors to CHANGE…
mydea Jun 13, 2024
d94695d
feat(feedback): Screenshots don't resize after cropping (#12481)
c298lee Jun 13, 2024
091cd3a
fix(tests): Update the expected status on 404. (#12483)
onurtemizkan Jun 13, 2024
073b649
ci: Fix node dependencies for CI jobs (#12484)
mydea Jun 13, 2024
1201eb2
feat(remix): Migrate to `opentelemetry-instrumentation-remix`. (#12110)
onurtemizkan Jun 13, 2024
1a2a33c
ref: Enable `noUncheckedIndexedAccess ` TS config (#12461)
mydea Jun 14, 2024
1bb86db
test(ref): Avoid some unnecessary conditions in tests (#12493)
mydea Jun 17, 2024
1b6c22e
feat(node): Allow to configure `maxSpanWaitDuration` (#12492)
mydea Jun 17, 2024
17a0f2e
feat(browser): Export `thirdPartyErrorFilterIntegration` from `@sentr…
Jun 17, 2024
d3ff316
fix(feedback): Fix scrolling after feedback submission (#12499)
c298lee Jun 17, 2024
62be087
ref(node) refactor contextlines to use readline (#12221)
JonasBa Jun 17, 2024
fdad379
feat(feedback): Improve screenshot quality for retina displays (#12487)
c298lee Jun 17, 2024
e77cb8f
feat(node) add max lineno and colno limits (#12514)
JonasBa Jun 17, 2024
a98ad0f
fix(remix): Export no-op as `captureRemixServerException` from client…
onurtemizkan Jun 17, 2024
b4b51c2
fix(remix): Add nativeFetch support for accessing request headers (#1…
kiliman Jun 17, 2024
8383f8d
feat(feedback): Allow passing `tags` field to any feedback config par…
ryan953 Jun 17, 2024
ff0d9c1
Revert "feat(node): Allow to configure `maxSpanWaitDuration`" (#12511)
mydea Jun 18, 2024
e0302c3
fix(feedback): Send feedback rejects invalid responses (#12518)
c298lee Jun 18, 2024
ce3e605
fix(nextjs): Update @rollup/plugin-commonjs (#12527)
AndreyKovanov Jun 18, 2024
a08335d
feat(react): Add React version to events (#12390)
AbhiPrasad Jun 18, 2024
2c12022
feat(replay): Add url to replay hydration error breadcrumb type (#12521)
ryan953 Jun 18, 2024
e9e862f
fix(profiling): continuous profile chunks should be in seconds (#12532)
JonasBa Jun 18, 2024
1d66b8a
fix(core): Ensure standalone spans respect sampled flag (#12533)
AbhiPrasad Jun 19, 2024
2fbd7cc
fix(core): Use maxValueLength in extra error data integration (#12174)
AbhiPrasad Jun 19, 2024
9724ec1
fix(node): Unify`getDynamicSamplingContextFromSpan` (#12522)
mydea Jun 19, 2024
13c5ebe
meta(changelog): Update changelog for 8.10.0
mydea Jun 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
68 changes: 56 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ jobs:
- 'packages/replay-canvas/**'
- 'packages/feedback/**'
- 'packages/wasm/**'
node: &node
- *shared
- 'packages/node/**'
- 'packages/opentelemetry/**'
browser_integration:
- *shared
- *browser
Expand All @@ -116,21 +120,21 @@ jobs:
- *shared
- *browser
- 'packages/ember/**'
node:
node_integration:
- *shared
- 'packages/node/**'
- *node
- 'dev-packages/node-integration-tests/**'
nextjs:
- *shared
- *browser
- *node
- 'packages/nextjs/**'
- 'packages/node/**'
- 'packages/react/**'
remix:
- *shared
- *browser
- *node
- 'packages/remix/**'
- 'packages/node/**'
- 'packages/react/**'
profiling_node:
- *shared
Expand All @@ -157,6 +161,7 @@ jobs:
changed_ember: ${{ steps.changed.outputs.ember }}
changed_remix: ${{ steps.changed.outputs.remix }}
changed_node: ${{ steps.changed.outputs.node }}
changed_node_integration: ${{ steps.changed.outputs.node_integration }}
changed_profiling_node: ${{ steps.changed.outputs.profiling_node }}
changed_profiling_node_bindings: ${{ steps.changed.outputs.profiling_node_bindings }}
changed_deno: ${{ steps.changed.outputs.deno }}
Expand Down Expand Up @@ -224,6 +229,44 @@ jobs:
message: |
⚠️ This PR is opened against **master**. You probably want to open it against **develop**.

job_external_contributor:
name: External Contributors
needs: job_install_deps
runs-on: ubuntu-20.04
if: |
github.event_name == 'pull_request'
&& (github.action == 'opened' || github.action == 'reopened')
&& github.event.pull_request.author_association != 'COLLABORATOR'
&& github.event.pull_request.author_association != 'MEMBER'
&& github.event.pull_request.author_association != 'OWNER'
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version-file: 'package.json'
- name: Check dependency cache
uses: actions/cache/restore@v4
with:
path: ${{ env.CACHED_DEPENDENCY_PATHS }}
key: ${{ needs.job_install_deps.outputs.dependency_cache_key }}
fail-on-cache-miss: true

- name: Add external contributor to CHANGELOG.md
uses: ./dev-packages/external-contributor-gh-action
with:
name: ${{ github.event.pull_request.user.login }}
- name: Create PR with changes
uses: peter-evans/create-pull-request@v6
with:
commit-message: "ref: Add external contributor to CHANGELOG.md"
title: "ref: Add external contributor to CHANGELOG.md"
branch: 'external-contributor/patch-${{ github.event.pull_request.user.login }}'
delete-branch: true
body: This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution.

job_build:
name: Build
needs: [job_get_metadata, job_install_deps]
Expand Down Expand Up @@ -824,7 +867,7 @@ jobs:
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration
Tests
needs: [job_get_metadata, job_build]
if: needs.job_get_metadata.outputs.changed_node == 'true' || github.event_name != 'pull_request'
if: needs.job_get_metadata.outputs.changed_node_integration == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-20.04
timeout-minutes: 15
strategy:
Expand Down Expand Up @@ -853,15 +896,15 @@ jobs:

- name: Overwrite typescript version
if: matrix.typescript
run: yarn add --dev --ignore-workspace-root-check typescript@${{ matrix.typescript }}
run: node ./scripts/use-ts-version.js ${{ matrix.typescript }}
working-directory: dev-packages/node-integration-tests

- name: Run integration tests
env:
NODE_VERSION: ${{ matrix.node }}
TS_VERSION: ${{ matrix.typescript }}
run: |
cd dev-packages/node-integration-tests
yarn test
working-directory: dev-packages/node-integration-tests
run: yarn test

job_remix_integration_tests:
name: Remix v${{ matrix.remix }} (Node ${{ matrix.node }}) Tests
Expand All @@ -874,10 +917,8 @@ jobs:
matrix:
node: [18, 20, 22]
remix: [1, 2]
# Remix v2 only supports Node 18+, so run Node 14, 16 tests separately
# Remix v2 only supports Node 18+, so run 16 tests separately
include:
- node: 14
remix: 1
- node: 16
remix: 1
steps:
Expand Down Expand Up @@ -999,8 +1040,11 @@ jobs:
'create-react-app',
'create-next-app',
'create-remix-app',
'create-remix-app-legacy',
'create-remix-app-v2',
'create-remix-app-v2-legacy',
'create-remix-app-express',
'create-remix-app-express-legacy',
'create-remix-app-express-vite-dev',
'node-express-esm-loader',
'node-express-esm-preload',
Expand Down
45 changes: 45 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,51 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 8.10.0

### Important Changes

- **feat(remix): Migrate to `opentelemetry-instrumentation-remix`. (#12110)**

You can now simplify your remix instrumentation by opting-in like this:

```js
const Sentry = require('@sentry/remix');

Sentry.init({
dsn: YOUR_DSN
// opt-in to new auto instrumentation
autoInstrumentRemix: true,
});
```

With this setup, you do not need to add e.g. `wrapExpressCreateRequestHandler` anymore. Additionally, the quality of the
captured data improves. The old way to use `@sentry/remix` continues to work, but it is encouraged to use the new setup.

### Other Changes

- feat(browser): Export `thirdPartyErrorFilterIntegration` from `@sentry/browser` (#12512)
- feat(feedback): Allow passing `tags` field to any feedback config param (#12197)
- feat(feedback): Improve screenshot quality for retina displays (#12487)
- feat(feedback): Screenshots don't resize after cropping (#12481)
- feat(node) add max lineno and colno limits (#12514)
- feat(profiling) add global profile context while profiler is running (#12394)
- feat(react): Add React version to events (#12390)
- feat(replay): Add url to replay hydration error breadcrumb type (#12521)
- fix(core): Ensure standalone spans respect sampled flag (#12533)
- fix(core): Use maxValueLength in extra error data integration (#12174)
- fix(feedback): Fix scrolling after feedback submission (#12499)
- fix(feedback): Send feedback rejects invalid responses (#12518)
- fix(nextjs): Update @rollup/plugin-commonjs (#12527)
- fix(node): Ensure status is correct for http server span errors (#12477)
- fix(node): Unify`getDynamicSamplingContextFromSpan` (#12522)
- fix(profiling): continuous profile chunks should be in seconds (#12532)
- fix(remix): Add nativeFetch support for accessing request headers (#12479)
- fix(remix): Export no-op as `captureRemixServerException` from client SDK (#12497)
- ref(node) refactor contextlines to use readline (#12221)

Work in this release was contributed by @AndreyKovanov and @kiliman. Thank you for your contributions!

## 8.9.2

- fix(profiling): Update exports so types generate properly (#12469)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,9 @@ window.Sentry = Sentry;

Sentry.init({
dsn: 'https://[email protected]/1337',
integrations: [Sentry.feedbackIntegration()],
integrations: [
Sentry.feedbackIntegration({
tags: { from: 'integration init' },
}),
],
});
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ sentryTest('should capture feedback', async ({ getLocalTestUrl, page }) => {
},
},
level: 'info',
tags: {
from: 'integration init',
},
timestamp: expect.any(Number),
event_id: expect.stringMatching(/\w{32}/),
environment: 'production',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ sentryTest('should capture feedback', async ({ forceFlushReplay, getLocalTestUrl
},
},
level: 'info',
tags: {},
timestamp: expect.any(Number),
event_id: expect.stringMatching(/\w{32}/),
environment: 'production',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ test('Sends a pageload transaction to Sentry', async ({ page }) => {
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
react: {
version: '18.2.0',
},
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
Expand Down Expand Up @@ -60,6 +63,9 @@ test('captures a navigation transcation to Sentry', async ({ page }) => {
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
react: {
version: '18.2.0',
},
trace: {
span_id: expect.any(String),
trace_id: expect.any(String),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/**
* This is intended to be a basic starting point for linting in your app.
* It relies on recommended configs out of the box for simplicity, but you can
* and should modify this configuration to best suit your team's needs.
*/

/** @type {import('eslint').Linter.Config} */
module.exports = {
root: true,
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
env: {
browser: true,
commonjs: true,
es6: true,
},

// Base config
extends: ['eslint:recommended'],

overrides: [
// React
{
files: ['**/*.{js,jsx,ts,tsx}'],
plugins: ['react', 'jsx-a11y'],
extends: [
'plugin:react/recommended',
'plugin:react/jsx-runtime',
'plugin:react-hooks/recommended',
'plugin:jsx-a11y/recommended',
],
settings: {
react: {
version: 'detect',
},
formComponents: ['Form'],
linkComponents: [
{ name: 'Link', linkAttribute: 'to' },
{ name: 'NavLink', linkAttribute: 'to' },
],
'import/resolver': {
typescript: {},
},
},
},

// Typescript
{
files: ['**/*.{ts,tsx}'],
plugins: ['@typescript-eslint', 'import'],
parser: '@typescript-eslint/parser',
settings: {
'import/internal-regex': '^~/',
'import/resolver': {
node: {
extensions: ['.ts', '.tsx'],
},
typescript: {
alwaysTryTypes: true,
},
},
},
extends: ['plugin:@typescript-eslint/recommended', 'plugin:import/recommended', 'plugin:import/typescript'],
},

// Node
{
files: ['.eslintrc.cjs', 'server.js'],
env: {
node: true,
},
},
],
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
node_modules

/.cache
/build
/public/build
.env
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { RemixBrowser, useLocation, useMatches } from '@remix-run/react';
import * as Sentry from '@sentry/remix';
import { StrictMode, startTransition, useEffect } from 'react';
import { hydrateRoot } from 'react-dom/client';

Sentry.init({
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: window.ENV.SENTRY_DSN,
integrations: [
Sentry.browserTracingIntegration({
useEffect,
useLocation,
useMatches,
}),
Sentry.replayIntegration(),
],
// Performance Monitoring
tracesSampleRate: 1.0, // Capture 100% of the transactions, reduce in production!
replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production.
replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur.
tunnel: 'http://localhost:3031/', // proxy server
});

Sentry.addEventProcessor(event => {
if (
event.type === 'transaction' &&
(event.contexts?.trace?.op === 'pageload' || event.contexts?.trace?.op === 'navigation')
) {
const eventId = event.event_id;
if (eventId) {
window.recordedTransactions = window.recordedTransactions || [];
window.recordedTransactions.push(eventId);
}
}

return event;
});

startTransition(() => {
hydrateRoot(
document,
<StrictMode>
<RemixBrowser />
</StrictMode>,
);
});
Loading
Loading