chore: Add aws/gcp serverless and deno to craft release registry target #12562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
chargome and
nicohrubec
and removed request for
a team
size-limit report 📦
|
mydea
reviewed
Jun 21, 2024
| 'npm:@sentry/nextjs': | ||
| onlyIfPresent: /^sentry-nextjs-\d.*\.tgz$/ | ||
| 'npm:@sentry/node': |
There was a problem hiding this comment.
h: I think you ordered this by name incorrectly, the order here is important! we need to have packages first that others depend on, e.g. react and node need to be higher in order before nextjs?
There was a problem hiding this comment.
does this ordering matter for the release registry? This only runs after we publish on npm too - so we should be good right?
There was a problem hiding this comment.
ahh ok, you are right of course. This is all a bit confusing! It confused me a bit because it says "npm:..."
mydea
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-release-registry#161 and #12442
Adds these packages to the craft config so they can be updated in the release registry.