Skip to content

docs: Add triaging docs #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2024
Merged

docs: Add triaging docs #12605

merged 3 commits into from
Jun 24, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 21, 2024

This adds docs about how to triage effectively. It is rather specific to this repository/team, but parts of it may also be relevant for outside contributors.

See https://github.com/getsentry/sentry-javascript/blob/fn/docs-triaging/docs/triaging.md

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this detailed documentation!

Comment on lines +32 to +34
Note that issues created by contributors themselves will not get this label applied. They will also not be added to the
"Web SDK Frontend" board automatically. You'll have to add the "Web SDK Frontend" project manually to issues you create
yourself as a contributor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: This seems a bit hard to read. Maybe restructure it a little bit?

Suggested change
Note that issues created by contributors themselves will not get this label applied. They will also not be added to the
"Web SDK Frontend" board automatically. You'll have to add the "Web SDK Frontend" project manually to issues you create
yourself as a contributor.
**Note for Contributors:** Note that issues created by contributors will not get this label applied. The issues will also not be added to the
"Web SDK Frontend" board automatically. You'll have to manually add the project "Web SDK Frontend" to issues you create yourself as a contributor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just about spacing? This is auto-formatted into these lines by prettier! (it should be rendered "normally" though)

Comment on lines +22 to +23
1. You can look at the `#feed-web-sdk` channel in Slack. This channel will automatically receive a message every day in
the morning with issues that require triaging.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention slack here? Feels a bit weird considering this is a public space, but might just be me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I was thinking about this too. IMHO it's not too bad to have this here, the alternative is to leave this out and have this one info somewhere in notion, but then this becomes dispersed again, which means nobody will find it etc 🤔

1. You can look at the `#feed-web-sdk` channel in Slack. This channel will automatically receive a message every day in
the morning with issues that require triaging.
2. You can look at the triage view in the Github Project Board: https://github.com/orgs/getsentry/projects/31/views/29
3. (Also for external contributors) You can filter by `Waiting for: Product Owner` label:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would exclusively do point 3 here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be especially for the team, and also for external contributors. I want this to be the thing that folks joining the team read to know what to do, which is usually not 3 here. Triaging is not that relevant for most external contributors (it may be sometimes, but way more important for us)

user replies again, the label will be re-added (indicating that a response from the repo owners is expected).

Note that issues created by contributors themselves will not get this label applied. They will also not be added to the
"Web SDK Frontend" board automatically. You'll have to add the "Web SDK Frontend" project manually to issues you create
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave out the board/project here since it's private.

docs/triaging.md Outdated
Comment on lines 62 to 64
You can and should also move issues through the project board. You can set the status to "Backlog" (may be done at some
point), "Todo" (should be done), "In Progress" (I am working on this), "In Review" (PR is open), or "Done". This helps
have an overview what is actively being worked on at any given time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again not sure mentioning the board here is nice, since its private.

@mydea mydea merged commit f905c98 into develop Jun 24, 2024
30 checks passed
@mydea mydea deleted the fn/docs-triaging branch June 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants