chore: Update changed package paths #12954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
nicohrubec and
andreiborza
and removed request for
a team
|
Could you give some background on this please? The changes look fine, just unsure what the implications are 😅. |
I updated the PR description with some more reasoning! |
andreiborza
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these while working on the cloudflare sdk.
We were previously referencing
packages/replay, which does not exist anymore. This updates us to use the correct paths.The nextjs sdk depends on vercel-edge, so we should be running tests for it when that package changes.
The deno sdk no longer relies on the browser sdk, this updates the paths accordingly
We can be smarter about CI time and only run bun tests when relevant package paths change.