Skip to content

ref(node): Split up nest integration into multiple files #13172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

nicohrubec
Copy link
Contributor

@nicohrubec nicohrubec commented Aug 2, 2024

The file implementing the nest integration in node got a bit annoying to work with, so splitting it up.

@nicohrubec nicohrubec marked this pull request as ready for review August 5, 2024 07:19
@nicohrubec nicohrubec requested review from a team, AbhiPrasad and andreiborza and removed request for a team August 5, 2024 07:20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giga nit: let's follow the conventions in the repo and name this sentryNestInstrumentaion.ts or sentry-nest-instrumentation.ts

@nicohrubec nicohrubec merged commit 7ad5054 into develop Aug 5, 2024
108 checks passed
@nicohrubec nicohrubec deleted the nh/refactor-nest branch August 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants