test: Fix flakey integration test #13253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Aug 6, 2024
mydea
added a commit
that referenced
this pull request
Aug 12, 2024
This PR streamlines and fixes some timing/cleanup issues we had in integration tests, which sometimes lead to issues. One problem was introduced here: #13253 This change lead to the server being shut down (because `done` is called) before the HTTP requests are finished, leading to error logs. Another problem was that in some cases we had leaking processes, where we did not properly close servers we started - this was everywhere we used `createTestServer`. I also moved some code from the node-integration-tests package to the remix package, that was only used there (and not properly depended/imported on). For future debugging, this was shown by running tests with `--detectOpenHandles`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsentry/sentry-javascript/actions/runs/10263576392/job/28396005694