Skip to content

docs(nuxt): Consistently use SENTRY_DSN env var in README examples #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

leopoldkristjansson
Copy link
Contributor

Mismatch in env var names in Readme. One was called DSN, the other SENTRY_DSN.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Mismatch in env var names in Readme. One was called DSN, the other SENTRY_DSN.
@lforst
Copy link
Contributor

lforst commented Aug 29, 2024

Hi, thanks for the PR! Would you mind doing it the other way around? So changing it to SENTRY_DSN in both places? That variable is more conventional and various 3rd party integrations (eg Vercel) we have are setting SENTRY_DSN. Thanks!

Unify the name of env var for dsn to be SENTRY_DSN.
@leopoldkristjansson
Copy link
Contributor Author

Hi, thanks for the PR! Would you mind doing it the other way around? So changing it to SENTRY_DSN in both places? That variable is more conventional and various 3rd party integrations (eg Vercel) we have are setting SENTRY_DSN. Thanks!

Yes, absolutely. Done.

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lforst lforst changed the title Mismatch in env var names in Readme docs(nuxt): Consistently use SENTRY_DSN env var in README examples Aug 30, 2024
@lforst lforst enabled auto-merge (squash) August 30, 2024 08:46
@lforst lforst merged commit 70ab8a9 into getsentry:develop Aug 30, 2024
120 checks passed
mydea pushed a commit that referenced this pull request Aug 30, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13524

Co-authored-by: lforst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants