fix: Fallback to <anonymous> handler name in mechanism #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a unit test could be added to this fix? This issue caused a production app of ours to fail |
HazAT
approved these changes
Jun 9, 2018
|
Should the current version 3.26.1 of Raven not be deprecated in npm? It is broken and produces errors in client-facing applications that are very hard to debug. |
|
@kamilogorek We should consider deprecating |
|
@willem-delbare just did exactly that. 3.26.0 and 3.26.1 are deprecated now and 3.26.2 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1358
Fixes: #1361
Completely forgot that anonymous functions have no names... We use
<unknown>for html elements, so<anonymous>sounds like a good name.